Skip to content

New iterative generators#661

Open
maximelucas wants to merge 9 commits intodevfrom
new_generators
Open

New iterative generators#661
maximelucas wants to merge 9 commits intodevfrom
new_generators

Conversation

@maximelucas
Copy link
Collaborator

@maximelucas maximelucas commented Feb 10, 2025

Added three iterative deterministic generators:

Code adapted from the "Higher-order Laplacian Renormalization" repo.

@codecov
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 48.75000% with 41 lines in your changes missing coverage. Please review.

Project coverage is 92.80%. Comparing base (18de14b) to head (cde2bc1).

Files with missing lines Patch % Lines
xgi/generators/iterative.py 48.10% 41 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #661      +/-   ##
==========================================
- Coverage   93.50%   92.80%   -0.71%     
==========================================
  Files          64       65       +1     
  Lines        5005     5085      +80     
==========================================
+ Hits         4680     4719      +39     
- Misses        325      366      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maximelucas
Copy link
Collaborator Author

@Marconurisso @MartaMorandini Can you check again that these two functions look correct? I wrote tests only for order=2 and n_iter up to 2, can you add basic ones for another value of order if it's worth it?

@maximelucas maximelucas marked this pull request as ready for review February 10, 2025 12:14
@maximelucas
Copy link
Collaborator Author

I've now also added an NGF function, please check that it's correct and we should add a few simple tests.

@nwlandry
Copy link
Collaborator

@maximelucas any updates on this?

@kaiser-dan kaiser-dan added the new feature New feature or request label Feb 26, 2026
@kaiser-dan kaiser-dan changed the base branch from main to dev February 26, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

incorporate pseudofractal generative models incorporate Network-Geometry-with-Flavor

3 participants