Fix WinRM wrong host and port. Fix require ssh_username when using WinRM #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RodyKossen
pushed a commit
that referenced
this pull request
Jul 17, 2025
Add the firmware argument to the builder documentation since it was missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code tries to run WinRM against the wrong host and wrong port.
ssh_usernameshould not be required when using WinRMThis PR probably won't get accepted due to the changes I've made in
step_connect_winrm.goBut it is what works for me.
Please consider fixing these issues if you will not merge this PR.