Add option for static IP #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@jdgoldie thanks for the submission (apologies for the delayed response!) I think that if a ssh_host is specified, the concept of the ip getter is not required, so I'd prefer not to add a new 'mode', rather, only use the ip getter in the case where an IP has not been specified (i.e. static). Can we break out that change from the additional disk one? As you've pointed out, that needs a bit of a clean up which I might be able to help with if I get some time. Thanks. |
RodyKossen
pushed a commit
that referenced
this pull request
Jul 17, 2025
feat: Make firmware configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rob,
I needed to build in a XEN Server in an environment where I have to use static IP. I added the ssh_host option and a setting for ip_getter that bypasses the VM IP discovery and uses the given value.