Allow ISO Storage repository to fallback to default SR if unspecified #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…os VMs can run kickstarter (albeit with errors)
Get the packer builder compiling and ensure that it can create terraform compatible VM templates
Add official binary releases
Remove unused replace directive in go.mod file
…er build if vif is failed to be created
Add start of centos 8 and ubuntu 20.04 examples
Upgrade builder to latest packer version
Remove hashicorps gpg github action to one that doesn't collide with Github's
(cherry picked from commit 2b2ba8540d1acfa0884e8db1367b32495bc39259)
…o-be-resilent-to-new-releases Update the ubuntu example to be resilient to ISO releases
…-example-to-be-resilent-to-new-releases Revert "Update the ubuntu example to be resilient to ISO releases"
…uploaded-each-time Prevent ISO used in iso builder from being uploaded if it already exists
Update ubuntu example to be resilient to upstream minor releases
Fixing documentation
Signed-off-by: AtaxyaNetwork <[email protected]>
s/SrName/SrISOName
Looks like the consts got moved into common
Solves TestBuilderPrepare_InvalidKey failing, since we weren't capturing it's errors before.
This aligns the Xenserver plugin to being a bit more inline with what Packer > 1.6.0 is expecting, since packer now simply ignores the iso_checksum_type (it's supposed to error out but that code path isn't working right now because we don't set PluginType in the configs. The unit tests have been altered to reflect this reality. Note that this isn't a comprehensive change; the config still has the inert ISOChecksumType, and there's probably a laundry list of other things that needs to be looked at, For now though, we have working unit tests again. Documentation from SDK has been aligned for iso_checksum
…generation and re-run it
…e_and_fix_tests Remove iso checksum type and fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#63 missed an update to the config structures.
Testing