Skip to content

Store non-ASCII chars as is to save disk space of JSON(L) files #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Store non-ASCII chars as is to save disk space of JSON(L) files #254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions chat_downloader/output/continuous_write.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def write(self, item, flush=False):
self.file.seek(0, os.SEEK_END) # Go to the end of file

to_write = json.dumps(
item, indent=self.indent, sort_keys=self.sort_keys)
item, ensure_ascii=False, indent=self.indent, sort_keys=self.sort_keys)
if self.indent is not None:
indent_padding = '\n' # to add on a new line
to_write = indent_padding + self._multiline_indent(to_write)
Expand Down Expand Up @@ -166,7 +166,7 @@ def __init__(self, file_name, sort_keys=True, **kwargs):
self.file = open(self.file_name, 'a', encoding='utf-8')

def write(self, item, flush=False):
print(json.dumps(item, sort_keys=self.sort_keys),
print(json.dumps(item, ensure_ascii=False, sort_keys=self.sort_keys),
file=self.file, flush=flush)


Expand Down