Skip to content

Fix twitch.tv parsing of CJK username #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix twitch.tv parsing of CJK username #226

wants to merge 3 commits into from

Conversation

JC-Chung
Copy link
Contributor

If display name with Chinese, Japanese, or Korean characters, the name will be incorrect.

@JC-Chung
Update twitch.py
cf4b0cc 
If display name with Chinese, Japanese, or Korean characters, the name will be incorrect.
glubsy
glubsy reviewed Sep 22, 2024
View reviewed changes
Copy link

@glubsy glubsy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not comment code and add your own, replace the code you wish to update instead.
Also make your PR title more descriptive like "Fix twitch.tv parsing of CJK username".
Other than that, looks good to me.

@JC-Chung JC-Chung changed the title Update twitch.py Fix twitch.tv parsing of CJK username Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@glubsy glubsy glubsy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JC-Chung @glubsy