Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update readme #8

Merged
merged 7 commits into from
Jan 14, 2025
Merged

chore: update readme #8

merged 7 commits into from
Jan 14, 2025

Conversation

sedzd
Copy link
Contributor

@sedzd sedzd commented Jan 14, 2025

Fix Session ID Validation and Improve API Clarity

Fixes server-side session key validation by properly base64 encoding the session key before RSA encryption, matching the Node.js implementation. This resolves the ALLOWED_SESSION_KEY_BYTE_SIZE validation error.

Additional improvements:

  • Deprecated ambiguous methods (getKey/getEncryptedKey) in favor of clearer naming
  • Updated tests to match new encryption flow
  • Updated README with correct usage examples

These changes ensure proper integration with Xendit's backend services.
Screenshot 2025-01-14 at 3 28 18 PM
Screenshot 2025-01-14 at 3 27 47 PM

@sedzd sedzd requested a review from UzaiSindiko January 14, 2025 07:40
@sedzd sedzd merged commit e11672e into main Jan 14, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants