Skip to content

Add type defs to Button component#92

Merged
xdmorgan merged 3 commits intomainfrom
feature/ts-button
Nov 28, 2020
Merged

Add type defs to Button component#92
xdmorgan merged 3 commits intomainfrom
feature/ts-button

Conversation

@xdmorgan
Copy link
Owner

@xdmorgan xdmorgan commented Nov 28, 2020

  • plus some tests
  • bumps react-scripts and typescript deps due to this vs code issue
    • plus, add .vscode/settings.json to specify workspace TS version (not editor's)

@codecov
Copy link

codecov bot commented Nov 28, 2020

Codecov Report

Merging #92 (fcc6811) into main (23c7668) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   65.52%   65.45%   -0.08%     
==========================================
  Files          55       55              
  Lines         525      521       -4     
  Branches      110      106       -4     
==========================================
- Hits          344      341       -3     
+ Misses        173      172       -1     
  Partials        8        8              
Impacted Files Coverage Δ
src/components/button.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23c7668...fcc6811. Read the comment docs.

@xdmorgan xdmorgan merged commit fba9bf0 into main Nov 28, 2020
@xdmorgan xdmorgan deleted the feature/ts-button branch November 28, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant