-
-
Notifications
You must be signed in to change notification settings - Fork 179
feat: Add support for runInTerminal request #966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #966 +/- ##
==========================================
- Coverage 67.10% 66.13% -0.97%
==========================================
Files 14 14
Lines 1988 2064 +76
Branches 393 415 +22
==========================================
+ Hits 1334 1365 +31
- Misses 654 699 +45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The dilemma here is that it's not trivial to track the spawned process and catch the exit event - and kill the right process. |
Yeah, as said, there are some tricky parts to this. I'll probably implement it in a way that you have to explicitly use it via the |
Support for console option with internalConsole, integratedTerminal and externalTerminal options