Skip to content

Conversation

@tomosonalawa
Copy link

In this commit, a few things were made:

  • a compiler definition USE_XCSP3 is used to know if we are allowed to use the XCSP3 parser headers
  • a cmake option 'NO_XCSP3' defined such that by default, XCSP3 is still used
  • define the cosoco binary only if XCSP3 is allowed
  • define the file 'utils/Constants.h' that provide the definition of 'STAR' if XCSP3 is not allowed, or include the XCSP3Constants.h to retrieve the definition of 'STAR'
  • provide a first implementation of the build-lib.sh script, meant to build the static library that has no dependency to libxml2 or XCSP3-Parser

…oes not have memory leak.

The type of Problem::variables has changed from vec to std::vector to ensure compatibility with std::unique_ptr
@tomosonalawa
Copy link
Author

Added new content:

  • some framework for testing (optional)
  • first pass at memory cleaning to reduce the amount of memory leaks

# Check if the 'no-xcsp3' option is enabled
option(NO_XCSP3 "Disable XCSP3 support" OFF)

set(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/main")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The definition of those path are now set to the build.sh file. That way, we can safely build the different versions in different folders without having to fear that one might contaminate the other.

@audemard
Copy link
Collaborator

Thanks for this pull request. I will work on it next week.

Best.

Gilles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants