Handle DEFERRABLE and NOT DEFERRABLE constraints in CREATE TABLE statements
#556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanslade
approved these changes
Dec 19, 2024
andrew-farries
force-pushed
the
fall-back-to-sql-for-generated-columns
branch
from
fa641ad to
01eb345
Compare
andrew-farries
force-pushed
the
handle-deferable-constraints-in-create-table
branch
from
9e26340 to
5fcd47c
Compare
andrew-farries
force-pushed
the
fall-back-to-sql-for-generated-columns
branch
from
01eb345 to
ef7cf14
Compare
andrew-farries
force-pushed
the
handle-deferable-constraints-in-create-table
branch
from
5fcd47c to
7888983
Compare
andrew-farries
force-pushed
the
fall-back-to-sql-for-generated-columns
branch
from
ef7cf14 to
ae7ba5f
Compare
andrew-farries
force-pushed
the
handle-deferable-constraints-in-create-table
branch
from
7888983 to
6d7bb59
Compare
andrew-farries
force-pushed
the
fall-back-to-sql-for-generated-columns
branch
from
ae7ba5f to
05706a1
Compare
andrew-farries
force-pushed
the
handle-deferable-constraints-in-create-table
branch
from
6d7bb59 to
714eb1c
Compare
andrew-farries
force-pushed
the
fall-back-to-sql-for-generated-columns
branch
from
05706a1 to
6be317b
Compare
andrew-farries
force-pushed
the
handle-deferable-constraints-in-create-table
branch
from
714eb1c to
f54ea25
Compare
Base automatically changed from
fall-back-to-sql-for-generated-columns
to
main
December 19, 2024 13:32
`NOT DEFERRABLE` constraints are the default behhavior in PostgreSQL, so they should be converted to the same operations as when `NOT DEFERRABLE` is not specified.
Deferrable constraints can't be represented by `pgroll` operations, so fall back to raw SQL for them.
andrew-farries
force-pushed
the
handle-deferable-constraints-in-create-table
branch
from
f54ea25 to
7e8ad0f
Compare
andrew-farries
deleted the
handle-deferable-constraints-in-create-table
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle
DEFERRABLEandNOT DEFERRABLEconstraints inCREATE TABLEstatementsNOT DEFERRABLEconstraints are the default, so add testcases to ensure that constraints with this modifier are converted toOpCreateTableoperations.DEFERRABLEconstraints and theINITIALLY IMMEDIATEandINITIALLY DEFERREDmodifiers are not supported, so fall back to raw SQL operations when these options are present.