Identify duplicated foreign key constraints by prefix #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When duplicating a column for backfilling, ensure that any FK constraints on the column are duplicated with a special prefix to identify them as duplicated constraints. Naming the duplicated FK constraint makes it easy for such constraints to be renamed on migration completion.
On migration completion, `RenameDuplicatedColumn` is called to rename a duplicated column along with any FK constraints that were created on the column. Ensure that the rename process only attempts to handle duplicated FK constraints by looking to the special name prefix.
There is no need to create FK constraints with a temporary name prefix - they only need to be validated on migration completion, not renamed.
Update test expectations now that FK constraints on duplicated columns have a special prefix.
exekias
approved these changes
Jan 19, 2024
Yes, that's it. We need to distinguish the case where the FK on a temporary column is a duplicate because an FK was already on the column when we set the column |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When duplicating a column for backfilling, ensure that any FK constraints on the column are duplicated with a special prefix to identify them as duplicated constraints. Naming the duplicated FK constraints in this way allows the rename process to ensure that it only attempts to rename duplicated FK constraints.