Add CI check for up-to-date type generation #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that type generation from `schema.json` is up-to-date. * Check out the repo * Run `make generate` * Ensure that there is no diff
exekias
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a CI check to ensure that the
types.gofile generated fromschema.jsonis up-to-date.Types are generated from the
schema.jsonfile but there was no check in place to ensure that the two were consistent.This PR runs
make generateto correct an inconsistency between the definitions and the generated types and adds the check so that we can't repeat this mistake.An example failed run where the types are out of date is here.