Fix previous version detection in the presence of inferred DDL migrations #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a column to record the kind of migration: 'pgroll' or 'inferred'.
Ensure that the previous version schema is removed when completing a migration. Separate the two cases: * The previous migration was a `pgroll` migration. * The previous migration was an inferred DDL migration.
Use a recursive CTE to find the first non-'inferred' parent of the current version.
exekias
reviewed
Nov 2, 2023
exekias
reviewed
Nov 2, 2023
exekias
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the definition of the
previous_versionfunction to use a recursive CTE to find the first non-'inferred' parent of the current version.This requires adding a new column to the
pgroll.migrationstable to record whether a migration is a pgroll migration or an inferred DDL change made outside of pgroll.Together, this means that the previous version schema is removed correctly when there have been inferred DDL changes between the current and previous pgroll migration.
Fixes #196