Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ping after creating connection #195

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

andrew-farries
Copy link
Collaborator

Ping the database after establishing a connection for better error messages.

Without this change, an error establishing a connection would be prefixed with the message from the next failure.

before:

Error: unable to set pgroll.internal to true: dial tcp [::1]:7432: connect: connection refused

after:

Error: dial tcp [::1]:7432: connect: connection refused 

Fixes #133

Ping the database after establishing a connection for better error
messages.
@andrew-farries andrew-farries merged commit 2429a6b into main Nov 2, 2023
22 checks passed
@andrew-farries andrew-farries deleted the leaner-error-messages branch November 2, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leaner error messages
2 participants