Convert schema-qualified CREATE TABLE statements (#557)

Ensure that schema qualified `CREATE TABLE` statements are correctly converted to a `migrations.OpCreateTable` operation.
xataio · Dec 19, 2024 · e1ba0af · e1ba0af
1 parent c64edc6
commit e1ba0af
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/pkg/sql2pgroll/create_table.go b/pkg/sql2pgroll/create_table.go
@@ -41,7 +41,7 @@ func convertCreateStmt(stmt *pgq.CreateStmt) (migrations.Operations, error) {
 
 	return migrations.Operations{
 		&migrations.OpCreateTable{
-			Name:    stmt.Relation.GetRelname(),
+			Name:    getQualifiedRelationName(stmt.GetRelation()),
 			Columns: columns,
 		},
 	}, nil

diff --git a/pkg/sql2pgroll/create_table_test.go b/pkg/sql2pgroll/create_table_test.go
@@ -24,6 +24,10 @@ func TestConvertCreateTableStatements(t *testing.T) {
 			sql:        "CREATE TABLE foo(a int)",
 			expectedOp: expect.CreateTableOp1,
 		},
+		{
+			sql:        "CREATE TABLE schema.foo(a int)",
+			expectedOp: expect.CreateTableOp17,
+		},
 		{
 			sql:        "CREATE TABLE foo(a int NULL)",
 			expectedOp: expect.CreateTableOp1,

diff --git a/pkg/sql2pgroll/expect/create_table.go b/pkg/sql2pgroll/expect/create_table.go
@@ -214,3 +214,14 @@ var CreateTableOp16 = &migrations.OpCreateTable{
 		},
 	},
 }
+
+var CreateTableOp17 = &migrations.OpCreateTable{
+	Name: "schema.foo",
+	Columns: []migrations.Column{
+		{
+			Name:     "a",
+			Type:     "int",
+			Nullable: true,
+		},
+	},
+}