Use raw SQL for indexes on expressions

xataio · Dec 21, 2024 · 5469ddc · 5469ddc
1 parent 9b0dec7
commit 5469ddc
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/pkg/sql2pgroll/create_index.go b/pkg/sql2pgroll/create_index.go
@@ -108,6 +108,12 @@ func canConvertCreateIndexStmt(stmt *pgq.IndexStmt) bool {
 	if stmt.GetIfNotExists() {
 		return false
 	}
+	// Indexes defined on expressions are not supported
+	for _, node := range stmt.GetIndexParams() {
+		if node.GetIndexElem().GetExpr() != nil {
+			return false
+		}
+	}
 
 	for _, param := range stmt.GetIndexParams() {
 		if param.GetIndexElem().GetCollation() != nil {

diff --git a/pkg/sql2pgroll/create_index_test.go b/pkg/sql2pgroll/create_index_test.go
@@ -148,6 +148,9 @@ func TestUnconvertableCreateIndexStatements(t *testing.T) {
 		"CREATE INDEX idx_name ON foo(a) NULLS NOT DISTINCT",
 		// IF NOT EXISTS is unsupported
 		"CREATE INDEX IF NOT EXISTS idx_name ON foo(a)",
+		// Indexes defined on expressions are not supported
+		"CREATE INDEX idx_name ON foo(LOWER(a))",
+		"CREATE INDEX idx_name ON foo(a, LOWER(b))",
 	}
 
 	for _, sql := range tests {