Fall back to raw SQL for COLLATE options

Column collation options are not representable by `pgroll` `Column` definitions.
xataio · Dec 18, 2024 · 3d33a39 · 3d33a39
1 parent a80d716
commit 3d33a39
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/pkg/sql2pgroll/create_table.go b/pkg/sql2pgroll/create_table.go
@@ -126,9 +126,12 @@ func canConvertColumnDef(col *pgq.ColumnDef) bool {
 	// Column storage options are not supported
 	case col.GetStorageName() != "":
 		return false
-		// Column compression options are not supported
+	// Column compression options are not supported
 	case col.GetCompression() != "":
 		return false
+	// Column collation options are not supported
+	case col.GetCollClause() != nil:
+		return false
 	default:
 		return true
 	}

diff --git a/pkg/sql2pgroll/create_table_test.go b/pkg/sql2pgroll/create_table_test.go
@@ -118,6 +118,9 @@ func TestUnconvertableCreateTableStatements(t *testing.T) {
 
 		// Column compression options are not supported
 		"CREATE TABLE foo(a text COMPRESSION pglz)",
+
+		// Column collation is not supported
+		"CREATE TABLE foo(a text COLLATE en_US)",
 	}
 
 	for _, sql := range tests {