[dotnet] Ensure appropriate IL Strip value for multi-rid builds

[haritha-mohan]

IsMultiRidBuild tracks if we are executing an inner build for a multi-rid case. With this approach, if the user specifies a value for EnableAssemblyILStripping it will still be honored. Otherwise, to ensure we don't duplicate assemblies when merging the app bundles due to a strip vs non-strip scenario, IL stripping for the multi-rid build is disabled by default.

There have been past examples of optimizing in the outer-build: #12847
But because IL Stripping is contingent on the evaluation of other RID-specific properties, not sure if that is a feasible approach here.

Fixes #17115

[vs-mobiletools-engineering-service2]

🔥 [CI Build] Build failed 🔥

Build failed for the job 'Build macOS tests'

Pipeline on Agent
Hash: c0299341c654f6b1d4eac1545ce3130276a9cb23 [PR build]

[rolfbjarne]

It would also be interesting to see the app size for a Release build of a Mac Catalyst app before and after this change.

[rolfbjarne]

This doesn't actually test the default value, since you're setting the value in the test.

You need to build for "Release", not set EnableAssemblyILStripping, and then verify that the app's assemblies are not stripped (when building for two runtime identifiers).

[github-actions]

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

[github-actions]

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

[vs-mobiletools-engineering-service2]

✅ API diff for current PR / commit

.NET (No breaking changes)

• iOS: vsdrops gist (No breaking changes)
• tvOS: vsdrops gist (No breaking changes)
• MacCatalyst: vsdrops gist (No breaking changes)
• macOS: vsdrops gist (No breaking changes)

✅ API diff vs stable

.NET (No breaking changes)

• iOS: vsdrops gist (No breaking changes)
• tvOS: vsdrops gist (No breaking changes)
• MacCatalyst: vsdrops gist (No breaking changes)
• macOS: vsdrops gist (No breaking changes)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 6f483ec9e82770ad25e60ca7b1c77afbb939afea [PR build]

[vs-mobiletools-engineering-service2]

✅ [CI Build] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 1c384fe38e5c9904c6b53a98a9d08a4785a7edc6 [PR build]

[vs-mobiletools-engineering-service2]

✅ [CI Build] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 1c384fe38e5c9904c6b53a98a9d08a4785a7edc6 [PR build]

[vs-mobiletools-engineering-service2]

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

19 tests crashed, 0 tests failed, 0 tests passed.

Failures

❌ cecil tests

🔥 Failed catastrophically on VSTS: test results - cecil (no summary found).

Html Report (VSDrops) Download

❌ dotnettests tests (iOS)

🔥 Failed catastrophically on VSTS: test results - dotnettests_ios (no summary found).

Html Report (VSDrops) Download

❌ dotnettests tests (MacCatalyst)

🔥 Failed catastrophically on VSTS: test results - dotnettests_maccatalyst (no summary found).

Html Report (VSDrops) Download

❌ dotnettests tests (macOS)

🔥 Failed catastrophically on VSTS: test results - dotnettests_macos (no summary found).

Html Report (VSDrops) Download

❌ dotnettests tests (Multiple platforms)

🔥 Failed catastrophically on VSTS: test results - dotnettests_multiple (no summary found).

Html Report (VSDrops) Download

❌ dotnettests tests (tvOS)

🔥 Failed catastrophically on VSTS: test results - dotnettests_tvos (no summary found).

Html Report (VSDrops) Download

❌ framework tests

🔥 Failed catastrophically on VSTS: test results - framework (no summary found).

Html Report (VSDrops) Download

❌ fsharp tests

🔥 Failed catastrophically on VSTS: test results - fsharp (no summary found).

Html Report (VSDrops) Download

❌ generator tests

🔥 Failed catastrophically on VSTS: test results - generator (no summary found).

Html Report (VSDrops) Download

❌ interdependent-binding-projects tests

🔥 Failed catastrophically on VSTS: test results - interdependent-binding-projects (no summary found).

Html Report (VSDrops) Download

❌ introspection tests

🔥 Failed catastrophically on VSTS: test results - introspection (no summary found).

Html Report (VSDrops) Download

❌ linker tests

🔥 Failed catastrophically on VSTS: test results - linker (no summary found).

Html Report (VSDrops) Download

❌ monotouch tests (iOS)

🔥 Failed catastrophically on VSTS: test results - monotouch_ios (no summary found).

Html Report (VSDrops) Download

❌ monotouch tests (MacCatalyst)

🔥 Failed catastrophically on VSTS: test results - monotouch_maccatalyst (no summary found).

Html Report (VSDrops) Download

❌ monotouch tests (macOS)

🔥 Failed catastrophically on VSTS: test results - monotouch_macos (no summary found).

Html Report (VSDrops) Download

❌ monotouch tests (tvOS)

🔥 Failed catastrophically on VSTS: test results - monotouch_tvos (no summary found).

Html Report (VSDrops) Download

❌ msbuild tests

🔥 Failed catastrophically on VSTS: test results - msbuild (no summary found).

Html Report (VSDrops) Download

❌ xcframework tests

🔥 Failed catastrophically on VSTS: test results - xcframework (no summary found).

Html Report (VSDrops) Download

❌ xtro tests

🔥 Failed catastrophically on VSTS: test results - xtro (no summary found).

Html Report (VSDrops) Download

Successes

Pipeline on Agent
Hash: 1c384fe38e5c9904c6b53a98a9d08a4785a7edc6 [PR build]

[vs-mobiletools-engineering-service2]

✅ [CI Build] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 1c384fe38e5c9904c6b53a98a9d08a4785a7edc6 [PR build]

[vs-mobiletools-engineering-service2]

❌ [CI Build] Tests on macOS M1 - Mac Monterey (12) failed ❌

Tests on macOS M1 - Mac Monterey (12) failed for unknown reasons.

Pipeline on Agent
Hash: 1c384fe38e5c9904c6b53a98a9d08a4785a7edc6 [PR build]

[vs-mobiletools-engineering-service2]

❌ [CI Build] Tests on macOS M1 - Mac Ventura (13) failed ❌

Tests on macOS M1 - Mac Ventura (13) failed for unknown reasons.

Pipeline on Agent
Hash: 1c384fe38e5c9904c6b53a98a9d08a4785a7edc6 [PR build]

[vs-mobiletools-engineering-service2]

❌ [CI Build] Tests on macOS arm64 - Mac Sequoia (15) failed ❌

Tests on macOS arm64 - Mac Sequoia (15) failed for unknown reasons.

Pipeline on Agent
Hash: 1c384fe38e5c9904c6b53a98a9d08a4785a7edc6 [PR build]

[vs-mobiletools-engineering-service2]

❌ [CI Build] Tests on macOS X64 - Mac Sonoma (14) failed ❌

Tests on macOS X64 - Mac Sonoma (14) failed for unknown reasons.

Pipeline on Agent
Hash: 1c384fe38e5c9904c6b53a98a9d08a4785a7edc6 [PR build]

[vs-mobiletools-engineering-service2]

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: 1c384fe38e5c9904c6b53a98a9d08a4785a7edc6 [PR build]