[Rgen] Set warnings to errors in the transformer tests.

Lets be strict in everythig we do, that includes tests. Set the warnings to be errors and fix the one we had.
xamarin · Jan 31, 2025 · 34e8bf4 · 34e8bf4
1 parent 53cbff0
commit 34e8bf4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/tests/rgen/Microsoft.Macios.Transformer.Tests/Attributes/StrongDictionaryDataTests.cs b/tests/rgen/Microsoft.Macios.Transformer.Tests/Attributes/StrongDictionaryDataTests.cs
@@ -34,7 +34,7 @@ interface AVCapturePhotoSettingsThumbnailFormat {
 }
 ";
 
-			yield return [(Source: strongDictionary, Path: "/some/random/path.cs"), new StrongDictionaryData ("AVCapturePhotoSettingsThumbnailFormatKeys")];
+			yield return [(Source: strongDictionary, Path: path), new StrongDictionaryData ("AVCapturePhotoSettingsThumbnailFormatKeys")];
 		}
 
 		IEnumerator IEnumerable.GetEnumerator () => GetEnumerator ();

diff --git a/tests/rgen/Microsoft.Macios.Transformer.Tests/Microsoft.Macios.Transformer.Tests.csproj b/tests/rgen/Microsoft.Macios.Transformer.Tests/Microsoft.Macios.Transformer.Tests.csproj
@@ -11,6 +11,14 @@
         <DotnetBuildDirectory>build/dotnet</DotnetBuildDirectory>
     </PropertyGroup>
 
+    <PropertyGroup Condition=" '$(Configuration)' == 'Debug' ">
+      <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+    </PropertyGroup>
+
+    <PropertyGroup Condition=" '$(Configuration)' == 'Release' ">
+      <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+    </PropertyGroup>
+
     <ItemGroup>
         <PackageReference Include="coverlet.collector" Version="6.0.2"/>
         <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.10.0"/>
-Original file line number
+Diff line change
@@ Expand Up / @@ -34,7 +34,7 @@ interface AVCapturePhotoSettingsThumbnailFormat { @@
     }
     ";
-    			yield return [(Source: strongDictionary, Path: "/some/random/path.cs"), new StrongDictionaryData ("AVCapturePhotoSettingsThumbnailFormatKeys")];
+    			yield return [(Source: strongDictionary, Path: path), new StrongDictionaryData ("AVCapturePhotoSettingsThumbnailFormatKeys")];
     		}
     		IEnumerator IEnumerable.GetEnumerator () => GetEnumerator ();
@@ Expand Down @@