Implement Eq and PartialEq for DashMap and DashSet#332
Merged
xacrimon merged 1 commit intoxacrimon:masterfrom Mar 5, 2025
Merged
Implement Eq and PartialEq for DashMap and DashSet#332xacrimon merged 1 commit intoxacrimon:masterfrom
xacrimon merged 1 commit intoxacrimon:masterfrom
Conversation
Owner
|
Hm, yes. You're right, this is an angle I didn't consider when I surely should have. Thanks for bringing this to my attention, I will merge this now, place a TODO to add a sentence or two in docs about this for tomorrow. Cheers mate. |
Contributor
Author
|
Legend, thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I was hoping to revisit #138, where you said
I agree with this entirely in the context of real, running code, but am hoping to change your mind on the basis of testing. Providing equality methods makes writing test cases that reason about the contents of
DashMap's andDashSet's much more concise, and testing is arguably the one scenario where ergonomics & readability clearly outweigh performance. Please consider giving users the option, even if you feel obligated to warn them against it, to use these traits.Happy to make any tweaks and add documentation at your request. Thanks for all the work on this project!