Add (try_)entry_ref functions and EntryRef types#331
Merged
xacrimon merged 2 commits intoxacrimon:masterfrom Feb 14, 2025
Merged
Add (try_)entry_ref functions and EntryRef types#331xacrimon merged 2 commits intoxacrimon:masterfrom
xacrimon merged 2 commits intoxacrimon:masterfrom
Conversation
Owner
|
lgtm |
Owner
|
@tfreiberg-fastly Probably a month or so out from a stable v7 release but you can use this funtionality today by pinning version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #183
Adds an EntryRef API similar to https://docs.rs/hashbrown/latest/hashbrown/hash_map/enum.EntryRef.html
The main difference is that I also added an OccupiedEntryRef type which can return the borrowed
&Qkey in thekey()function and it means thatVacantEntryRef::insert_entrydoesn't have to convert from&QtoKtwiceBTW, nice job moving to the detached guards, that made this very easy!