Provisional Feature/netcore integration #436
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trimmed public surface areas slightly
Reinstate tests in Devops
… trait to allow CI filtering Rationale: So we get a clean build through and can track fixes and further regressions. Expected 16 skipped tests (actually 18 due to skipped Theorys)
TODO: SolidFactory.Build(IfcHalfSpaceSolid) implementation Fixed Build Warning in XbimSolidSet
…ondeterministic ordering or tests
Rationale: don't overload the logs (e.g. Seq) with lots of Information logs at volume Information = all is well at a high level in the process. Started / Finished a job etc Warning = you probably want to fix this (but... don't want to overload the user, or us, with them) Debug = to help with diagnostics when things are not as expected. we fixed and issue and carried on Error = Something broke irreparably- the end result is probably not what was hoped for
…tion rather than the wrapper. Add context to the logger scope so output is the same. This preserves stack traces etc at the top level. The wrapper exception will typically get logged higher in the stack anyway.
Sensitive to environmental factors and other machine activities
Rerun failed tests up to 3 times - for occasional transient issues
Fixed issue in XbimGeometryCreator where loggerScope was leaking TODO: Logging needs centralising
TODO: Work out what's up with with the new GE.Tests (had to revert to Interop.Tests project
No changes to tests or GE itself.
Feature/netcore fixup of 'srl' branch which had diverged from feature/netcore Fixed Cylindrical Surfaces in advanced breps ModelServices Refactored Renamed Tests Integrated DI & logging changes
Try to use 'dotnet nuget push' over 'nuget push' so we can feed timeout
Fix RunSettingsFilePath misspelled x86 condition.
Added documentation to the DynamicDeflection and XbimMeshSimplifier
Ignore hollow circles inner diameter when it is less than zero
…icRepresentationContexts without subContext. Also support displaying of non-standard SurfaceModel representations - via optional setting on ModelContext
Updated test Dlls and test projects to net8.0
I have a few models that fail with a memory violation exception when building wires for IIfcIndexedPolyCurve. The error occurs in the EXEC_NATIVE->BuildWire call and results in a crash, but only when executed in multithreading. EXEC_NATIVE->BuildWire is not thread safe, so I've added a lock guard to ensure that each call waits for the completion of the previous and the crash is prevented. Other changes are introduced to improve the trace logging to investigate unexpected crashes in win x64 environments on third party comptuters that are difficult to reproduce. The regression exe has been changed to allow for engine selection configuration. FactoryBase.h has been changed to provide more consistent logging messages across configurations.
FIX: Parallelism failure in IIfcIndexedPolyCurve
Replace std::mutex by std::shared_mutex
I.e. only when analyzer notifies a valid shape.
Fixed calling the simplification of the resulting shape of Boolean operation in NBooleanFactory only when safe (after analyzing).
Fixed building composite curve 2d segments for raw conics and trimmed/offset conics
…ceptions during concurrent IfcGradientCurve processing
…ve-build-race Fix race condition in BuildCurve causing false "previously failed" exceptions during concurrent IfcGradientCurve processing
Fixed Swept Disk Solids parameterization semantics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.