Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port tasks to new rcx-version #84

Closed
wants to merge 181 commits into from
Closed

Port tasks to new rcx-version #84

wants to merge 181 commits into from

Conversation

newhinton
Copy link

@newhinton newhinton commented Jul 23, 2020

This updates the tasks-branch from rclone to rcx and the changes made since the fork

Closes #146, #38, #61 and i guess it closes #128 aswell

Todo:

  • Migrate Export/Import to JSON
  • -> when making an export, it should export tasks, triggers and the rclone config as a zip file
  • Switch Export filestorage to non-deprecated one (Implement Task to quickly sync files #37 (comment))
  • Use proper logging (Implement Task to quickly sync files #37 (comment))
  • Fix naming in DatabaseHandler
  • (Go over all of this: 2a19150)
  • Fix Crash in Triggerfragment when no tasks are defined
  • Discuss naming of things (tasks/trigger)
  • Fix theming not applied in new Activities (I dont quite get why it's not working, it should)
  • Add SharedPreferences to backup.zip
  • After restoring backups, the app crashes because restoring prefs introduces an error to taskdecription (Theming: sharedPref's use color value and color resource id inconsistent #157)
  • when no tasks are defined, the button linking to tasks should not only open the tasklist but the taskcreation activity aswell
  • also, maybe add a cool message that there are no tasks?
  • remove logging that was left somewhere
  • task list icons are not properly stored/used
  • fix back button behaviour on fragments
  • Investigate why disabled-state is beeing ignored by the trigger
  • Add task-stacking, so that tasks scheduled at the same time are not lost

In the future:
I want to investigate how exactly rcx behaves when multiple tasks are run simultaneous. The resulting information can be used to extend the trigger mechanism, so that it would be possible to run a task after a different task was run

  • extend triggermechanism (maybe)
  • Folderpicker for remotes (In the future. Maybe. Maybe not.)
  • Status Indicator for task (Last run succeded, failed or is currently running)
  • Add special task to export backup to remote so that rcx can backup itself
  • Check regularly for storage access, because tasks "fail silently" with successmessages when it cannot access internal storage

Those ideas will very likely not be in this PR

@newhinton newhinton mentioned this pull request Jul 23, 2020
20 tasks
@newhinton
Copy link
Author

This also fixes a small bug which generally blocks uploading when it only should block it when not on wifi

@LukeCode
Copy link

Works very well! Thanks for your work!

Copy link

@iamtalhaasghar iamtalhaasghar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@newhinton There are conflicts which need to be resolved manually.
Is this feature similar to rclone-browser's tasks?

@newhinton
Copy link
Author

@iamtalhaasghar I need to update my branch to the latest anyway, so i'll do that.

Can you give me a link to the rclone-browser you mean?

# Conflicts:
#	app/build.gradle
#	app/src/main/AndroidManifest.xml
#	app/src/main/res/values/strings.xml
#	gradle/wrapper/gradle-wrapper.properties
@iamtalhaasghar
Copy link

@newhinton
Copy link
Author

Yes, i believe they are quite similar. My PR allows you to define a folder and a target, which can then be triggered by an external app.

Im currently working on a trigger-system, so that tasks can directly be scheduled via rcx, i expect this to be working shortly

@newhinton
Copy link
Author

This now contains a trigger mechanism in addition to tasks

@newhinton
Copy link
Author

newhinton commented Jun 12, 2021

Edit: Moved todo to description

@newhinton
Copy link
Author

I capsuled the rclone processcall, because when it was not supplied by a build, the app just crashes. We should never crash, and this should trigger a more or less appropriate errormessage. (8d4b122)
This was a bit offtopic from the initial pr, but to be honest, this has gotten out of hand anyway :D

@newhinton
Copy link
Author

I have created a fork and development continues over at my repository.

(If i have any signed CLA's, please consider them revoked for now.)

@newhinton newhinton closed this Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Photo sync Crash when retrieving thumbnail URL from SAF
10 participants