make ege compatible with clang #122
Open
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirsz-ever
reviewed
May 8, 2022
| @@ -76,14 +76,18 @@ static int g_initoption = INIT_DEFAULT; | |||
| static HWND g_attach_hwnd = 0; | |||
| static WNDPROC DefWindowProcFunc = NULL; | |||
|
|
|||
| #ifndef __clang__ | |||
There was a problem hiding this comment.
这段为啥要改，应该没问题啊。
也可以把判断 __cplusplus 的部分去掉。
chirsz-ever
reviewed
May 8, 2022
| @@ -78,11 +81,13 @@ | |||
|
|
|||
| // MSVC 从 10.0（VS2010）开始有 stdint.h | |||
| // GCC 从 4.5 开始有 stdint.h | |||
| #ifndef __clang__ | |||
There was a problem hiding this comment.
这里改成在第 85 行加上 || defined(__clang__) 吧
|
So, 合吗， 各位 |
|
冲突了诶... |
|
@royqh1979 还在不， 解决一下冲突呢? |
|
@yixy-only 看看呢， 这个跟现在的cmake冲突挺大的， 要手动解决一下然后合入吗 |
这个等我先测一下 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.