register mixer2_gated_rms_norm ir kernel#7
Open
wxsIcey wants to merge 3 commits intoluka/vllm-ir/rms-normfrom
Open
register mixer2_gated_rms_norm ir kernel#7wxsIcey wants to merge 3 commits intoluka/vllm-ir/rms-normfrom
wxsIcey wants to merge 3 commits intoluka/vllm-ir/rms-normfrom
Conversation
Signed-off-by: Icey <1790571317@qq.com>
Signed-off-by: Icey <1790571317@qq.com>
Signed-off-by: Icey <1790571317@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Register
mixer2_rms_norm_gatedas a vllm IR op and rewriteMixer2RMSNormGated.forward_nativeto dispatch correctly across all tensor-parallel configurations.The implementation handles four cases:
n_groups=1,tp_size>1n_groups=1,tp_size=1n_groups>1,n_groups % tp_size != 0n_groups>1,n_groups % tp_size == 0Cases 2 and 4 require no collective communication and are handled by the IR op. Cases 1 and 3 require cross-rank communication that cannot be fused into a single kernel, so they are handled with explicit AllReduce / AllGather before calling into local computation.
Because
forward_nativenow covers all cases (including the optimized IR op paths for cases 2 and 4),forward_cudais fully redundant and can be removed.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.