Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -807,7 +807,7 @@ lazy val httpCodeGen =
),
libraryDependencies ++= Seq(
// Use swagger-parser only for validating YAML format in tests
"io.swagger.parser.v3" % "swagger-parser" % "2.1.35" % Test,
"io.swagger.parser.v3" % "swagger-parser" % "2.1.36" % Test,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency and better maintainability, it's a good practice to define dependency versions as vals at the top of the build.sbt file, as is done for other dependencies like AIRSPEC_VERSION, SLF4J_VERSION, etc. Please define a SWAGGER_PARSER_VERSION and use it here.

For example, you could add this near the other version definitions:

val SWAGGER_PARSER_VERSION = "2.1.36"

And then use it here.

        "io.swagger.parser.v3" % "swagger-parser" % SWAGGER_PARSER_VERSION % Test,

// Swagger includes dependency to SLF4J, so redirect slf4j logs to airframe-log
"org.slf4j" % "slf4j-jdk14" % SLF4J_VERSION % Test,
// For gRPC route scanner test
Expand Down
Loading