-
Notifications
You must be signed in to change notification settings - Fork 71
Update protobuf-java to 4.32.1 #4039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update to
protobuf-javaversion4.32.1is incorrect and will cause issues. According to the official Protocol Buffers documentation, the 4.x releases are for Java Lite and C# users, while regular Java users should stick to the 3.x series. This project usesgrpc-protobufversion1.75.0, which depends onprotobuf-javaversion3.25.3. Introducingprotobuf-java4.x will create a version conflict and lead to binary incompatibilities, likely resulting inNoSuchMethodErroror otherLinkageErrors at runtime. This change should be reverted. It would be best to close this PR and configure Scala Steward to ignore this and future 4.x updates forprotobuf-java.