feat: add mapWithCompletion and flatMapWithCompletion for safe stream cancellation #3955
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue where users cannot safely cancel Rx streams from within operator functions without encountering concurrent modification exceptions.
Problem
The original issue was that calling
c.cancelfrom within a map function creates a concurrent modification problem:Solution
Added two new methods that allow operators to safely signal completion by returning
None:mapWithCompletion[B](f: A => Option[B]): Rx[B]flatMapWithCompletion[B](f: A => Option[RxOps[B]]): Rx[B]These methods follow the same pattern as the existing
TakeOpimplementation, where returningNonetriggers anOnCompletionevent and stops further processing withRxResult.Stop.Usage Example
Implementation Details
MapWithCompletionOpandFlatMapWithCompletionOpto represent these operatorsRxRunnerthat properly emitsOnCompletionevents whenNoneis returnedmapandflatMapmethods are unchangedTesting
scalafmtAllto follow project conventionsFixes #3689.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.