Skip to content

Feat flexible crs #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
e-lo wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Feat flexible crs #139

e-lo wants to merge 2 commits into from

Conversation

@e-lo
Copy link
Collaborator

@e-lo e-lo commented Apr 4, 2022

Functionality:

  • Adds util.update_crs_nodes_df()
  • uses update_crs_nodes_df() to change CRS on write out in roadway.py
  • uses update_crs_nodes_df() to change CRS on read-in from cube in project.py

Tests:

  • To add.

Errata:

  • Black formatting

Closes issue #135

@e-lo e-lo changed the base branch from master to develop April 4, 2022 23:17
@e-lo e-lo requested a review from i-am-sijia April 4, 2022 23:17
@e-lo e-lo self-assigned this Apr 19, 2022
@e-lo e-lo requested a review from DavidOry April 19, 2022 15:47
@e-lo
Copy link
Collaborator Author

e-lo commented Apr 19, 2022

@i-am-sijia or @DavidOry can you please review so @RachelWikenMC can start using this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@i-am-sijia i-am-sijia Awaiting requested review from i-am-sijia

@DavidOry DavidOry Awaiting requested review from DavidOry

Assignees

@e-lo e-lo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@e-lo