-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom attributes in system schema #425
Fix custom attributes in system schema #425
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (23.33%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #425 +/- ##
============================================
- Coverage 30.50% 30.49% -0.02%
- Complexity 1009 1010 +1
============================================
Files 134 134
Lines 13245 13275 +30
Branches 2546 2552 +6
============================================
+ Hits 4041 4048 +7
- Misses 8703 8724 +21
- Partials 501 503 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PR builder started |
ExtensionAttributeSchemaConfig schemaAttributeConfig = | ||
new ExtensionAttributeSchemaConfig | ||
(schemaConfiguration.getProperties()); | ||
attributeConfigs.put(schemaAttributeConfig.getURI(), schemaAttributeConfig); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (schemaAttributeConfig.getURI().startsWith(EXTENSION_ROOT_ATTRIBUTE_URI)) {
attributeConfigs.put(schemaAttributeConfig.getURI(), schemaAttributeConfig);
}
Better to add this check since this readConfiguration method is called from public buildSystemSchemaExtension method, so we can not guarantee only system schema related attributes are sent there.
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13320849240
Related Issues