Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom attributes in system schema #425

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

amanda-ariyaratne
Copy link
Contributor

@amanda-ariyaratne amanda-ariyaratne commented Feb 13, 2025

@amanda-ariyaratne amanda-ariyaratne marked this pull request as draft February 13, 2025 21:28
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 23.33333% with 23 lines in your changes missing coverage. Please review.

Project coverage is 30.49%. Comparing base (2789631) to head (1cd171c).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
.../core/config/SCIMSystemSchemaExtensionBuilder.java 0.00% 15 Missing ⚠️
...charon3/core/schema/SCIMResourceSchemaManager.java 50.00% 5 Missing and 2 partials ⚠️
.../org/wso2/charon3/core/extensions/UserManager.java 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (23.33%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #425      +/-   ##
============================================
- Coverage     30.50%   30.49%   -0.02%     
- Complexity     1009     1010       +1     
============================================
  Files           134      134              
  Lines         13245    13275      +30     
  Branches       2546     2552       +6     
============================================
+ Hits           4041     4048       +7     
- Misses         8703     8724      +21     
- Partials        501      503       +2     
Flag Coverage Δ
unit 29.73% <23.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashensw ashensw marked this pull request as ready for review February 14, 2025 01:51
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13320849240

ExtensionAttributeSchemaConfig schemaAttributeConfig =
new ExtensionAttributeSchemaConfig
(schemaConfiguration.getProperties());
attributeConfigs.put(schemaAttributeConfig.getURI(), schemaAttributeConfig);
Copy link
Contributor

@PasinduYeshan PasinduYeshan Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (schemaAttributeConfig.getURI().startsWith(EXTENSION_ROOT_ATTRIBUTE_URI)) {
attributeConfigs.put(schemaAttributeConfig.getURI(), schemaAttributeConfig);
}

Better to add this check since this readConfiguration method is called from public buildSystemSchemaExtension method, so we can not guarantee only system schema related attributes are sent there.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13320849240
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13320849240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants