-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip the validation for integer type with empty values. #421
Skip the validation for integer type with empty values. #421
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #421 +/- ##
============================================
+ Coverage 28.57% 30.12% +1.55%
- Complexity 921 979 +58
============================================
Files 133 134 +1
Lines 13041 13203 +162
Branches 2512 2537 +25
============================================
+ Hits 3726 3978 +252
+ Misses 8832 8716 -116
- Partials 483 509 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12988399007
@@ -109,6 +112,10 @@ protected static boolean isAttributeDataTypeValid(Object attributeValue, | |||
case DECIMAL: | |||
return attributeValue instanceof Double; | |||
case INTEGER: | |||
// Skipping the empty string check for integer attributes since this is the value clear use case. | |||
if (StringUtils.isEmpty(attributeValue.toString())) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can attribute value be null here?
Purpose
Related issues
Approach