Repository navigation
Remove redundant dependencies from pom files in ai-service, user-mgt and user-store components - #8338
Conversation
…and user-store components
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
💤 Files with no reviewable changes (3)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThree Maven POM files remove redundant or superseded dependency and plugin declarations. The remaining declarations retain the provided logging scope, the original action dependency, and the configured Surefire version. ChangesAI service logging dependency
Password action dependency
User store Surefire plugin
Priority: ➖ Normal Change: Bug fix Merge Risk: ⚪ Minimal · up to No actionable regression was established in the dependency or plugin cleanup. The change is mergeable after normal build checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description clearly explains the build failure and root cause, but it omits most template sections, including Goals, Approach, User stories, Release note, Documentation, Testing, Security checks, and other repository-required sections. Resolution Complete the required template sections. Add the goals, implementation approach, user stories, release note, documentation impact, training, certification, marketing, automation test results, security checks, samples, related PRs, migration impact, test environment, and learning details. Enter N/A with a brief explanation where a section does not apply.
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
|
|
||
| <dependencies> | ||
| <dependency> | ||
| <groupId>org.ops4j.pax.logging</groupId> |
There was a problem hiding this comment.
Kept the dependency in
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.wso2.carbon.identity.framework</groupId> |
There was a problem hiding this comment.
Kept the dependency in
| <plugins> | ||
|
|
||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> |
There was a problem hiding this comment.
Kept the plugin in
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8338 +/- ##
==========================================
Coverage 53.68% 53.69%
+ Complexity 22659 22622 -37
==========================================
Files 2264 2264
Lines 138114 138122 +8
Branches 22886 23873 +987
==========================================
+ Hits 74140 74158 +18
+ Misses 55047 55033 -14
- Partials 8927 8931 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
left a comment
jenkins-is-staging
left a comment
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/37895419274
3 participants
Purpose
Fixes the PR builder failure caused by duplicate dependency and plugin declarations in three POMs:
[ERROR] The build could not read 3 projects
... 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique ...
... 'build.plugins.plugin.(groupId:artifactId)' must be unique ...
Root cause
The GitHub
ubuntu-24.04runner image was updated from20260927.320to20261004.327. Its release changelog upgrades Mavenfrom 3.9.16 to 3.10.0 (under Project Management).
pr-builder.ymldoesn't pin a Maven version, so it picked up 3.10.0.The Maven 3.10.0 release notes list this under "Potentially Breaking Core Changes":
These duplicates have been in the repo for a while. Maven 3.9.x only reported them as warnings.