Skip to content

Introduce version filtering for pre-issue access token action(v2) and extend OAuth grant type support#7658

Draft
Lashen1227 wants to merge 4 commits intowso2:masterfrom
Lashen1227:feat/pre-issue-access-token-action-token-exchange
Draft

Introduce version filtering for pre-issue access token action(v2) and extend OAuth grant type support#7658
Lashen1227 wants to merge 4 commits intowso2:masterfrom
Lashen1227:feat/pre-issue-access-token-action-token-exchange

Conversation

@Lashen1227
Copy link
Copy Markdown
Member

@Lashen1227 Lashen1227 commented Dec 17, 2025

This pull request introduces version-aware filtering for action execution requests and updates configuration and test resources to support new OAuth grant types and action versioning. The main changes enhance backward compatibility for action types and ensure the system recognizes newer action versions and additional grant flows.

Version-aware filtering and backward compatibility:

  • Added actionVersion as a parameter to RequestFilter.getFilteredHeaders and getFilteredParams methods, allowing filtering logic to distinguish between v1 and v2 (or later) actions for PRE_ISSUE_ACCESS_TOKEN. This preserves backward compatibility for v1 actions while enforcing stricter rules for v2 and above.
  • Introduced the private helper method isV2OrLater in RequestFilter.java to determine action version and apply appropriate filtering logic.

Configuration updates:

  • Updated the default server feature configuration to set the latest version of pre_issue_access_token actions to v2, reflecting the new versioning logic.
  • Added support for new OAuth grant types (token exchange, device code, jwt bearer, saml2 bearer, organization switch) in both test (rulemeta/flows.json) and server feature resources, ensuring the system can recognize and handle these flows.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 17, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 7e1b60f0-5881-4901-8024-78547c316840

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.37%. Comparing base (6e1b88e) to head (6231154).
⚠️ Report is 652 commits behind head on master.

Files with missing lines Patch % Lines
.../action/execution/internal/util/RequestFilter.java 30.00% 3 Missing and 4 partials ⚠️
...ternal/service/impl/ActionExecutorServiceImpl.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #7658      +/-   ##
============================================
- Coverage     49.84%   49.37%   -0.48%     
- Complexity    19869    20461     +592     
============================================
  Files          2144     2147       +3     
  Lines        132858   148824   +15966     
  Branches      27664    32971    +5307     
============================================
+ Hits          66228    73476    +7248     
- Misses        58214    66074    +7860     
- Partials       8416     9274     +858     
Flag Coverage Δ
unit 37.06% <42.85%> (+1.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Lashen1227 Lashen1227 changed the title Add token exchange grant and update pre-issue access token v2 Extend grant types and update pre-issue access token v2 Feb 16, 2026
@Lashen1227 Lashen1227 changed the title Extend grant types and update pre-issue access token v2 Introduce version filtering for pre-issue access token action(v2) and extend OAuth grant type support Mar 5, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 5, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant