Open
Conversation
Merging in changes from develop
Merging develop and main
- Add ParamSpec type system supporting year, date, and categorical params - Create ParamEditor popover with range sliders and segmented toggles - Add buildTileUrl to resolve path tokens and query params in tile URLs - Add configurable_params to land cover (year), grasslands (year), and tree cover loss (start/end year range) - Wire param changes through to tile URL updates and context store
Only two years are available, so a segmented toggle is clearer than a slider with just min/max stops.
- Remove hardcoded year range from tree cover loss title - Add categorical year detection to deriveDateRange so land cover (2015/2024 toggle) shows its selected year in the legend header - Date ranges now update dynamically when params change, both from manual selection and AI-triggered layer adds
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
|
Hello - I'd like to pause this one until the layer manager is in and then we can go over this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a ParamEditor settings popover to legend layers, allowing users to adjust dataset parameters (year, year range) directly from the legend. Parameter changes update the tile URL and legend header in real time.
Previously, dataset tile URLs were static — users couldn't change the year for land cover or adjust the date
range for tree cover loss. This wires up configurable parameters so the legend becomes interactive, not just
informational.
Layer setting changes are purely visual to aid exploration! Settings update the map tiles and legend header but the assistant is not aware of the current state i.e no context chips set. We need to figure out a way to make the map↔chat state sync bidirectionally. For now an approach for Tree cover threshold and DIST confidence params is also deferred to a future PR.
How it works
strategy (query or path), and optional range grouping for dual-handle sliders
untouched
dual-handle range slider for grouped year params, single slider for standalone year. Also houses the opacity
slider (moved from the old standalone OpacityControl)
update as the user changes settings
Datasets configured
Commits
component, opacity absorbed, default param resolution, styling polish
a slider; initialise draft with spec defaults so the toggle shows the active value on mount
active params including categorical year detection