Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
solomon-negusse
requested review from
danscales,
dmannarino,
gtempus,
jterry64 and
manukala6
danscales
left a comment
danscales
left a comment
There was a problem hiding this comment.
Looks good (thought I didn't go through the analysis in detail). Great documentation at the top (just had a few comments). Since the area zarr is a float64, I think all the area computations should be done in float64,, which is what we want (as you discovered).
| "\n", | ||
| "### 5. Configure and Run\n", | ||
| "\n", | ||
| "1. Set the latest GNW pipeline Docker image from [ECR](https://us-east-1.console.aws.amazon.com/ecr/repositories/private/084375562450/analytics-api?region=us-east-1) (Zeno account) for the Dask cluster to use (`COILED_CLUSTER_IMAGE` variable)\n", |
There was a problem hiding this comment.
This is a bit unclear. Do you mean that I set the COILED_CLUSTER_IMAGE environment variable to this URL: https://us-east-1.console.aws.amazon.com/ecr/repositories/private/084375562450/analytics-api?region=us-east-1 , OR do I click on the top image on that page, and use that URL, or what?
There was a problem hiding this comment.
Actually, do we need to set it here, or actually you need to change the setting of COILED_CLUSTER_IMAGE in the lab code, right? So, I guess you want to say in these instructions that you get the URL of the top image (I think?) and put that in the code where COILED_CLUSTER_IMAGE is set. (Or you can put this whole comment right there in the code?)
2 participants
Address GTC-3412. Instructions in the notebook.