Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge static libs and bump version 2.2-3 #8

Merged
merged 30 commits into from
Dec 4, 2024

Conversation

ElliotScher
Copy link
Contributor

WPIcal had linker errors related to the Ceres dependency.

publish.gradle Outdated Show resolved Hide resolved
publish.gradle Outdated Show resolved Hide resolved
ElliotScher and others added 2 commits December 1, 2024 00:26
Copy link
Contributor

@Gold856 Gold856 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9 will be changing how the x86 Windows libraries are built to match ARM Windows. As far I can tell, the only changes you need to make are including libf2c into the base inputFiles array and using gflags_static and gflags_static_debug instead of just gflags and gflags_debug.

Also, consider specifying the file extension when you iterate over inputFiles instead of specifying it for all the individual libraries. I think it's more readable with less file extensions.

publish.gradle Outdated Show resolved Hide resolved
Co-authored-by: Gold856 <[email protected]>
@ElliotScher
Copy link
Contributor Author

are gflags_static and gflags_static_debug the libs for windows? on my linux machine they are gflags and gflags_debug

@Gold856
Copy link
Contributor

Gold856 commented Dec 3, 2024

Yes.
image

@PeterJohnson PeterJohnson merged commit 234c509 into wpilibsuite:main Dec 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants