Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wpiunits] EnergyUnit and VoltageUnit reworked as not BaseUnits. Added more generated divs and times for existing Dimensions #7473

Closed
wants to merge 5 commits into from
Closed

[wpiunits] EnergyUnit and VoltageUnit reworked as not BaseUnits. Added more generated divs and times for existing Dimensions #7473

wants to merge 5 commits into from

Conversation

narmstro2020
Copy link
Contributor

Summary of Changes

  1. So in the existing units library EnergyUnit and VoltageUnit are listed as base types. This goes against the SI definition and can easily be replaced with mult and per units. EnergyUnit has been made a MultUnit<ForceUnit, DistanceUnit>
    VoltageUnit has been made a PerUnit<PowerUnit, CurrentUnit>
  2. some of the combine methods didn't seem quite right so mult and per methods were built in to replace them especially in Power, Energy, Current, and Voltage
  3. Generated dimension operations for Power = Torque * AngularVelocity

@narmstro2020 narmstro2020 requested a review from a team as a code owner December 1, 2024 21:52
@narmstro2020
Copy link
Contributor Author

/pregen

@narmstro2020
Copy link
Contributor Author

/pregen

@narmstro2020
Copy link
Contributor Author

whats the issues with the pregenerated files.

@Gold856
Copy link
Contributor

Gold856 commented Dec 2, 2024

Fixed by #7474

@narmstro2020
Copy link
Contributor Author

/pregen

@narmstro2020
Copy link
Contributor Author

Any thoughts/feedback on this PR

@narmstro2020
Copy link
Contributor Author

I'm going to go ahead and close this one. May revisit later.

1 similar comment
@narmstro2020
Copy link
Contributor Author

I'm going to go ahead and close this one. May revisit later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@narmstro2020 @Gold856