Fix #8540: disable delete buttons when CDN is paused - #8578
Open
faisalahammad wants to merge 1 commit into
Open
Conversation
- build_page_row() now uses should_disable_element_for_rocketcdn() to decide the disabled class - delete buttons get wpr-cdn-disabled when subscription is loading, CDN is paused, licence is invalid, or no active subscription - added unit tests for build_page_row covering all disable states Fixes wp-media#8540
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delete buttons (bin icons) on the RocketCDN Free page list stay active while the CDN is paused. This change uses the existing
should_disable_element_for_rocketcdn()helper to apply thewpr-cdn-disabledclass, which disables the buttons when the CDN is paused, the subscription is loading, the licence is invalid, or there is no active subscription.Fixes #8540
Changes
inc/Engine/CDN/Render/Controller.php
Before:
After:
Why:
should_disable_element_for_rocketcdn()already covers all the states that should disable CDN UI elements (loading, paused, expired licence, no active subscription). Using it here keeps the delete buttons consistent with the purge section, exclude section, and exclusion fields.Testing
Test 1: Delete buttons disabled when CDN is paused
Result: bin icon is greyed out and not clickable
Test 2: Delete buttons enabled when CDN is active
Result: page is removed as expected