fix(license): correct French promo banner translations - #8572
Open
faisalahammad wants to merge 1 commit into
Open
fix(license): correct French promo banner translations#8572faisalahammad wants to merge 1 commit into
faisalahammad wants to merge 1 commit into
Conversation
- Translate promo name via translate_promo_name() so 'Anniversary' becomes 'Anniversaire'. - Fix French wording: accélérez -> accélérer, remove extra 'sur'/'de', and fix CTA button. - Update DisplayPromoBanner unit test to stub __(). Fixes wp-media#8548
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 54 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed French translation mistakes in dashboard promo banner. The promo name "Anniversary" was not translatable, and several French strings had grammatical errors.
Fixes #8548
Changes
inc/Engine/License/Upgrade.php
Before:
After:
Added
translate_promo_name()method that wraps promo names with__()for translation. Currently handles "Anniversary" → "Anniversaire".Why: Promo names come from API as English strings. Need translation layer for non-English sites.
languages/rocket-fr_FR.po
Before:
After:
Also added translation entry:
Why: Fixed 4 translation errors:
Testing
Test 1: French promo banner displays correctly
Result: French translations display correctly with proper grammar.
Test 2: English promo banner unchanged
Result: English translations work as before.
All unit tests pass (10/10), PHPCS clean, PHPStan no errors.