This repository was archived by the owner on Jul 23, 2024. It is now read-only.
Fix: Internal server error 500 for relationship to non-published post #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #300, #85, #100
If non-published post is set for relationship field, it causes 500 internal server error when users without role to see the post try to fetch the field.
In the PR #286, @matt-antone used a condition check
$post_object->status === 'publish'to fix this issue.Instead of that, in this PR, I used
WPGraphQL\Model\Model::get_visibility()function to check if the user have the proper permission to read the post.