will not cache null values anymore

wp-bond · Dec 22, 2022 · efa909e · efa909e
1 parent ca72203
commit efa909e
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/src/Services/Cache/FileCache.php b/src/Services/Cache/FileCache.php
@@ -58,8 +58,10 @@ public function remember(
 
             $value = $this->value($value);
 
-            // store
-            Filesystem::put($path, serialize($value));
+            // store only if not null
+            if ($value !== null) {
+                Filesystem::put($path, serialize($value));
+            }
 
             return $value;
         }
@@ -93,9 +95,12 @@ public function set($key, $value, $ttl = null): bool
         $path = $this->keyPath((string) $key, true);
         $value = $this->value($value);
 
-        // store
-        Filesystem::put($path, serialize($value));
-        return true;
+        // store only if not null
+        if ($value !== null) {
+            Filesystem::put($path, serialize($value));
+            return true;
+        }
+        return false;
 
         // ttl is not used on file cache
         // other providers may