sui: update to new package system #4639
Open
+1,500
−2,048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcsongor
force-pushed
the
sui-package-update
branch
2 times, most recently
from
db38960 to
49fc651
Compare
3 tasks
kcsongor
force-pushed
the
sui-package-update
branch
from
49fc651 to
7e2cea9
Compare
douglasgalico
previously approved these changes
Jan 18, 2026
kcsongor
force-pushed
the
sui-package-update
branch
from
035e325 to
535a3a9
Compare
kcsongor
force-pushed
the
sui-package-update
branch
from
08dcd3f to
11db301
Compare
kcsongor
force-pushed
the
sui-package-update
branch
3 times, most recently
from
cf3fd2c to
5918741
Compare
kcsongor
force-pushed
the
sui-package-update
branch
8 times, most recently
from
1476c22 to
185729b
Compare
kcsongor
force-pushed
the
sui-package-update
branch
5 times, most recently
from
4286096 to
93c0282
Compare
kcsongor
force-pushed
the
sui-package-update
branch
from
b0e095c to
95c6466
Compare
kcsongor
force-pushed
the
sui-package-update
branch
5 times, most recently
from
962f9a9 to
b039d37
Compare
With the new Move package management system (Sui 1.63+), packages no longer have explicit addresses in Move.toml. The package address is 0x0 at compile time and gets assigned at publish time. This broke tests because: 1. sui::package::test_publish creates an UpgradeCap with the given package ID 2. If we pass 0x0, authorize_upgrade fails with EAlreadyAuthorized because it checks cap.package != 0x0 3. assert_package_upgrade_cap derives expected addresses from types, which are 0x0 at test time, but our UpgradeCap needs a non-zero address fix: - Add TEST_PACKAGE_ADDR constants with non-zero dummy addresses - Add complete_test_only() functions that skip the package address check - Update test scenarios to use the new test-only setup functions
kcsongor
force-pushed
the
sui-package-update
branch
from
b039d37 to
a5b87e0
Compare
kcsongor
force-pushed
the
sui-package-update
branch
from
a5b87e0 to
ce176c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the sui packages the new package system that was introduced in Sui 1.63 (https://github.com/MystenLabs/sui/blob/main/external-crates/move/crates/move-package-alt/MIGRATION.md).
This should hopefully allow downstream users of the wormhole packages to depend on a single branch/commit, and switch between networks (mainnet/testnet/local) easily.