feat: update to entirely rely on OTEL config #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenvoke
force-pushed
the
feature/otel-config
branch
from
b700a52 to
fd12161
Compare
owenvoke
force-pushed
the
feature/otel-config
branch
from
147fc5b to
95916f3
Compare
owenvoke
force-pushed
the
feature/otel-config
branch
3 times, most recently
from
5326d06 to
d2d7acd
Compare
owenvoke
force-pushed
the
feature/otel-config
branch
from
d2d7acd to
cda0794
Compare
alberthaff
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates to remove the
telemetry.enabledconfig key, and move to fully match the OTEL SDK configuration. This makes usage easier, and also means that "no-op" instances will be used, rather than returningnullfor the bindings.It also cleans up nnecessary code complication (e.g. the full initialisation of
MeterProvider), ensures that changes to the config in runtime apply to the OTEL SDK, and adds some initial tests.