Subscriber detail stats #21982
Draft
Subscriber detail stats #21982
+164
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Project dependencies changeslist! Upgraded Dependencies
rs.wordpress.api:android:trunk-5e2baf62aea0fd14efa95d3a533e846faeb9cc64, (changed from trunk-ba6df4e8adfec6c14d6fa58af3717d2297d431fa)
rs.wordpress.api:kotlin:trunk-5e2baf62aea0fd14efa95d3a533e846faeb9cc64, (changed from trunk-ba6df4e8adfec6c14d6fa58af3717d2297d431fa)tree-\--- rs.wordpress.api:android:trunk-ba6df4e8adfec6c14d6fa58af3717d2297d431fa
- +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
- +--- com.squareup.okhttp3:okhttp-tls:4.12.0
- | +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
- | +--- com.squareup.okio:okio:3.6.0 -> 3.9.0 (*)
- | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
- +--- net.java.dev.jna:jna:5.17.0
- +--- rs.wordpress.api:kotlin:trunk-ba6df4e8adfec6c14d6fa58af3717d2297d431fa
- | +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
- | +--- com.squareup.okhttp3:okhttp-tls:4.12.0 (*)
- | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2 (*)
- | \--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 -> 2.1.21 (*)
- \--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 -> 2.1.21 (*)
+\--- rs.wordpress.api:android:trunk-5e2baf62aea0fd14efa95d3a533e846faeb9cc64
+ +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+ +--- com.squareup.okhttp3:okhttp-tls:4.12.0
+ | +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+ | +--- com.squareup.okio:okio:3.6.0 -> 3.9.0 (*)
+ | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
+ +--- net.java.dev.jna:jna:5.17.0
+ +--- rs.wordpress.api:kotlin:trunk-5e2baf62aea0fd14efa95d3a533e846faeb9cc64
+ | +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+ | +--- com.squareup.okhttp3:okhttp-tls:4.12.0 (*)
+ | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2 (*)
+ | \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 (*)
+ \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 (*) |
|
| App Name |  WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21982-f954dfe | |
| Commit | f954dfe | |
| Direct Download | wordpress-prototype-build-pr21982-f954dfe.apk |
|
| App Name |  Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21982-f954dfe | |
| Commit | f954dfe | |
| Direct Download | jetpack-prototype-build-pr21982-f954dfe.apk |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #21982 +/- ##
=======================================
Coverage 39.02% 39.02%
=======================================
Files 2153 2153
Lines 101494 101494
Branches 15585 15585
=======================================
Hits 39613 39613
Misses 58384 58384
Partials 3497 3497 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the subscriber detail feature by fetching and displaying subscriber stats along with the subscriber details.
- Updated dependency version for wordpress-rs in the versions TOML file
- Implemented subscriber stats fetching in SubscribersViewModel and added a new method in SubscriberDetailViewModel
- Updated UI components in SubscribersActivity and SubscriberDetailScreen to display stats and support clickable email/URL actions
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| gradle/libs.versions.toml | Updated dependency version for wordpress-rs |
| WordPress/src/main/res/drawable/ic_email_open.xml | Added a new vector drawable for representing email opened state |
| WordPress/src/main/java/org/wordpress/android/ui/subscribers/SubscribersViewModel.kt | Added state management and coroutine-driven fetching of subscriber stats |
| WordPress/src/main/java/org/wordpress/android/ui/subscribers/SubscribersActivity.kt | Integrated new click actions for email and url links, passing required state to the detail screen |
| WordPress/src/main/java/org/wordpress/android/ui/subscribers/SubscriberDetailViewModel.kt | Added functionality to fetch subscriber details along with stats |
| WordPress/src/main/java/org/wordpress/android/ui/subscribers/SubscriberDetailScreen.kt | Updated UI components to display real timing stats and to allow clickable interactions for email/URL |
Comments suppressed due to low confidence (1)
WordPress/src/main/java/org/wordpress/android/ui/subscribers/SubscriberDetailViewModel.kt:33
- Initializing wpComApiClient asynchronously in the init block may lead to a race condition if fetchSubscriberWithStats is invoked before the initialization completes. Consider using dependency injection or a synchronous initialization to guarantee that wpComApiClient is ready when needed.
wpComApiClient = WpComApiClient(
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the subscriber feature by fetching and displaying subscriber stats for the detail screen.
To test