Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat-fe: 이메일 전송 낙관적 업데이트 제거 및 전송 내역 인터벌 패치 #1013

Open
wants to merge 4 commits into
base: fe/develop
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 13, 2025

목적

백엔드 스키마 변경에 따라 isSucceed 속성을 status로 변경합니다.

작업 세부사항

  • Email 스키마를 isSucceed -> status로 변경
  • 이메일 전송 낙관적 업데이트 제거
  • 전송 내역 패치 interval 적용

참고사항

백엔드 작업 병합 후 머지해야 합니다!

closes #1012

@github-actions github-actions bot added feature 새로운 기능 frontend 프론트엔드 labels Feb 13, 2025
@github-actions github-actions bot added this to the 스프린트 7.0 milestone Feb 13, 2025
@llqqssttyy llqqssttyy marked this pull request as ready for review February 17, 2025 07:44
@llqqssttyy llqqssttyy requested a review from lurgi February 17, 2025 07:44
Copy link
Contributor Author

1739778278.275009

Copy link
Contributor Author

1739778291.384229

Copy link
Contributor

@lurgi lurgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

인터벌로 잘 바꿔주셨네요! 👍
한가지 걸리는 부분은, '이메일 탭'을 누른 상태에서 모달을 닫아도, refetch가 계속해서 일어난다는 점입니다.
모달이 사라지는게 아니라 숨겨지는거라서 그런 듯 한데, 이부분 수정이 필요해 보여요!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 새로운 기능 frontend 프론트엔드
Projects
Status: 검토중
Development

Successfully merging this pull request may close these issues.

2 participants