feat-be: Email 전송 상태값 종류 추가 #1011
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
1739435703.921449 |
cutehumanS2
approved these changes
Feb 13, 2025
Comment on lines
+54
to
+55
| log.info("이메일 전송 실패: from={}, to={}, subject={}, error={}", from.getId(), to.getEmail(), subject, e.getMessage()); | ||
| email.updateStatus(EmailStatus.FAILED); |
There was a problem hiding this comment.
[필수 반영x]
사소한 부분인데, 둘 순서를 바꾸는 게 아주 조오금 더 안정성 있지 않을까요? ㅎ ㅎ
로그에서도 상태를 안 찍고 있기도 하고, 그럴 일이 있을까 싶지만 왠지 상태를 바꾸고 나서 로깅 하는 게 안정적인 거 같아서요~
| SET email_status = CASE | ||
| WHEN email_status = '1' THEN 'DELIVERED' | ||
| WHEN email_status = '0' THEN 'FAILED' | ||
| ELSE 'PENDING' |
There was a problem hiding this comment.
'PENDING'은 필요 없을 거 같긴 한데, 혹시 모르니 해 놓는 게 좋을까요?
| @@ -338,7 +338,7 @@ void read() { | |||
| fieldWithPath("subject").description("이메일 제목"), | |||
| fieldWithPath("content").description("이메일 본문"), | |||
| fieldWithPath("createdDate").description("전송 날짜"), | |||
| fieldWithPath("isSucceed").description("전송 성공 여부") | |||
| fieldWithPath("status").description("이메일 상태 (PENDING, DELIVERED, FAILED)") | |||
There was a problem hiding this comment.
[필수 반영x]
이메일 상태 -> 이메일 전송 상태 로 하는 게 명확한 거 같아요 ㅎ ㅎ
| ELSE 'PENDING' | ||
| END; | ||
|
|
||
| ALTER TABLE email MODIFY COLUMN email_status VARCHAR(20) NOT NULL DEFAULT 'PENDING'; |
There was a problem hiding this comment.
맨 위 alter table에 합치면 혹시 결과가 다른가요? ?
ALTER TABLE email CHANGE COLUMN is_succeed email_status VARCHAR(20) NOT NULL DEFAULT 'PENDING';
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
목적
현재 이메일 전송시 전송을 성공/실패 했는지만 Boolean 값으로 저장되고 있습니다.
이를 Enum을 사용하여 전송 상태값의 종류를 다양하게 만듭니다.(전송 중/ 전송 성공/ 전송 실패)
작업 세부사항
isSucceed필드 변경참고 사항
PENDING상태에서 추후DELIVERED,FAILED로 상태가 바뀌는 지에 대한 테스트를 어떻게 작성할지 의견이 필요합니다~EMAIL_SEND_STATUS
closes #1010