Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare npm publish #8

Merged
merged 2 commits into from
Apr 24, 2023
Merged

prepare npm publish #8

merged 2 commits into from
Apr 24, 2023

Conversation

nogw
Copy link
Contributor

@nogw nogw commented Apr 23, 2023

Goals

Ensure the package is ready for publication.

Description

Before publishing a package to npm, it's important to ensure that it meets certain requirements, such as having a properly configured package.json file, including necessary dependencies, build scripts, and typeScript configuration.

Changes

  • Added a missing tsconfig.json file.
  • Added type annotations.
  • Added a build script that uses Rollup
  • Created an entry point (index.ts) to properly expose the code.

Related Issues

sibelius
sibelius approved these changes Apr 23, 2023
View reviewed changes
Copy link
Member

@sibelius sibelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let user bring their own fetch implementation

@sibelius sibelius merged commit b3132cc into woovibr:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sibelius sibelius

@fersilva16 fersilva16

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

before to publish to npm, it should be a package npm Exists the index.js in the codebase?
3 participants
@nogw @sibelius @fersilva16