fix: error when trying to save mock request file that doesn't exist #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edumaciel10
reviewed
Apr 26, 2023
src/apiCache.ts
Outdated
Comment on lines
52
to
55
| if (err && err.code !== 'ENOENT') { | ||
| // eslint-disable-next-line | ||
| console.log({ err }); | ||
| } |
There was a problem hiding this comment.
I think that this not is the best solution for your problem
Try to find the root cause
edumaciel10
approved these changes
Apr 26, 2023
fersilva16
suggested changes
Apr 26, 2023
fersilva16
approved these changes
Apr 26, 2023
edumaciel10
requested changes
Apr 26, 2023
|
done, using |
fersilva16
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in issue #10, if the file "mock-requests.json" does not exist and you run the command "WRITE_MOCK=true yarn es scripts/test.ts", an error message will be shown, however, the file is created in any case
Changes
Related Issues