test: link title with bare > and newline panics subtokenize#211
Open
ChristianMurphy wants to merge 1 commit intowooorm:mainfrom
Open
test: link title with bare > and newline panics subtokenize#211ChristianMurphy wants to merge 1 commit intowooorm:mainfrom
> and newline panics subtokenize#211ChristianMurphy wants to merge 1 commit intowooorm:mainfrom
Conversation
`to_html_with_options("[x](/x \"> \n\")", &Options::default())` panics
in 1.0.0 release at `src/subtokenize.rs:149` with `expected link`. The
13-byte input is a link with quoted title containing `> ` followed by a
newline; the parser's link-chain consumer reaches an event whose `link`
field is `None` (added by attention.rs without a `Link` payload) and
unconditionally `expect`s it.
Same panic site as wooormGH-79 (`[](a (a \n))`) but distinct input shape.
A single chain-builder integrity fix in `src/construct/label_end.rs`
(or wherever the chain is spliced) likely closes both shapes together.
Verified to fail against `markdown = "=1.0.0"` in release. Found via
in-tree fuzzing campaign.
Related-to: wooormGH-79.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to_html_with_options("[x](/x \"> \n\")", &Options::default())panics in 1.0.0 release atsrc/subtokenize.rs:149withexpected link. The 13-byte input is a link with quoted title containing>followed by a newline; the parser's link-chain consumer reaches an event whoselinkfield isNone(added by attention.rs without aLinkpayload) and unconditionallyexpects it.Same panic site as GH-79 (
[](a (a \n))) but distinct input shape. A single chain-builder integrity fix insrc/construct/label_end.rs(or wherever the chain is spliced) likely closes both shapes together.Verified to fail against
markdown = "=1.0.0"in release. Found via in-tree fuzzing campaign.Related-to: GH-79.